Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a condition to allow Docker to fully setup during post-create #694

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

jasonviviano
Copy link
Contributor

Description

Fixes post-create error Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? during K8 cluster creation

@jasonviviano jasonviviano requested a review from a team as a code owner October 24, 2023 19:59
Copy link
Contributor

@Reshrahim Reshrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the getting-started guide from codespaces spin from this branch and it works! Thanks Jason for finding a solution.

@jasonviviano jasonviviano merged commit 3b5c020 into edge Oct 24, 2023
9 of 13 checks passed
@jasonviviano jasonviviano deleted the jasonviviano/codespace-fix branch October 24, 2023 20:46
Reshrahim added a commit that referenced this pull request Oct 24, 2023
* k8s guestbook application example for use in tutorial (#626)

* copy over k8s guestbook application example for use in tutorial

Signed-off-by: Will Tsai <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jonathan Smith <[email protected]>

---------

Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>

* Upmerge 10-24 (#695)

* Update get.radapp.dev references (#625)

* Update get.radapp.dev refernces

* Update vscode extension install

* Update eShop Readme with new url links (#647)

* Fix edge version download (#685)

* Add Kuberenetes tutorial content (#620)

* Add Kuberenetes tutorial content

* Update demo/Chart/values.yaml

Co-authored-by: Aaron Crawfis <[email protected]>

* Update demo/Chart/values.yaml

Co-authored-by: Aaron Crawfis <[email protected]>

* k8s guestbook application example for use in tutorial (#626)

* copy over k8s guestbook application example for use in tutorial

Signed-off-by: Will Tsai <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jonathan Smith <[email protected]>

---------

Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>

* Rebase to v0.26

* move chat templatesto samples

---------

Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>

* Revert changes to test.yaml

---------

Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: James Montemagno <[email protected]>
Co-authored-by: Ryan Nowak <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>

* Added a condition to allow Docker to fully setup during post-create before initializing the K3d cluster (#694)

Co-authored-by: Reshma Abdul Rahim <[email protected]>

---------

Signed-off-by: Will Tsai <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: James Montemagno <[email protected]>
Co-authored-by: Ryan Nowak <[email protected]>
Co-authored-by: jasonviviano <[email protected]>
AaronCrawfis added a commit that referenced this pull request Oct 31, 2023
* k8s guestbook application example for use in tutorial (#626)

* copy over k8s guestbook application example for use in tutorial

Signed-off-by: Will Tsai <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jonathan Smith <[email protected]>

---------

Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>

* Upmerge 10-24 (#695)

* Update get.radapp.dev references (#625)

* Update get.radapp.dev refernces

* Update vscode extension install

* Update eShop Readme with new url links (#647)

* Fix edge version download (#685)

* Add Kuberenetes tutorial content (#620)

* Add Kuberenetes tutorial content

* Update demo/Chart/values.yaml

Co-authored-by: Aaron Crawfis <[email protected]>

* Update demo/Chart/values.yaml

Co-authored-by: Aaron Crawfis <[email protected]>

* k8s guestbook application example for use in tutorial (#626)

* copy over k8s guestbook application example for use in tutorial

Signed-off-by: Will Tsai <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jonathan Smith <[email protected]>

---------

Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>

* Rebase to v0.26

* move chat templatesto samples

---------

Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>

* Revert changes to test.yaml

---------

Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: James Montemagno <[email protected]>
Co-authored-by: Ryan Nowak <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>

* Added a condition to allow Docker to fully setup during post-create before initializing the K3d cluster (#694)

Co-authored-by: Reshma Abdul Rahim <[email protected]>

* conditional push to ghcr

* nit

* fix

* nit

* delete az login since unneccessary

* add comment

* nit

* review comments

---------

Signed-off-by: Will Tsai <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: James Montemagno <[email protected]>
Co-authored-by: Ryan Nowak <[email protected]>
Co-authored-by: jasonviviano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants